Workaround for issue #3642. #3670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, there are nil values stored in the uidMatrix, which results in a segmentation fault when trying to access the Uids field. The root cause of this issue is still unclear but this change adds an additional check to prevent the segmentation fault.
golangcibot
reviewed
Jul 15, 2019
manishrjain
approved these changes
Jul 15, 2019
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @martinmr)
query/groupby.go, line 230 at r2 (raw file):
continue } for _, uid := range ul.Uids {
Fix is good. But, I wonder: Can you change this to ul.GetUids() instead? Would the effect be the same?
martinmr
commented
Jul 15, 2019
There was a problem hiding this comment.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @manishrjain and @martinmr)
query/groupby.go, line 230 at r2 (raw file):
Previously, manishrjain (Manish R Jain) wrote…
Fix is good. But, I wonder: Can you change this to ul.GetUids() instead? Would the effect be the same?
I think so. This is the definition of GetUids:
func (m *List) GetUids() []uint64 {
if m != nil {
return m.Uids
}
return nil
}
I'll make the change.
dna2github
pushed a commit
to dna2fork/dgraph
that referenced
this pull request
Jul 19, 2019
For some reason, there are nil values stored in the uidMatrix, which results in a segmentation fault when trying to access the Uids field. The root cause of this issue is still unclear but this change adds an additional check to prevent the segmentation fault.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, there are nil values stored in the uidMatrix, which
results in a segmentation fault when trying to access the Uids field.
The root cause of this issue is still unclear but this change adds an
additional check to prevent the segmentation fault.
This change is